Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make e and f flags mutually exclusive #6976

Merged
merged 2 commits into from
May 9, 2017

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Apr 26, 2017

makes -e and -f mutually exclusive, which also eliminates concatenation between the two

this is part of the changes described in #6926

@jsvd jsvd requested a review from ph April 26, 2017 14:32
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM waiting for CI.

@suyograo
Copy link
Contributor

@jsvd remember to tag it as breaking :)

@jsvd jsvd force-pushed the make_flags_e_f_mutually_exclusive branch from 86d8a03 to e8cf527 Compare May 3, 2017 08:15
@jsvd jsvd closed this May 3, 2017
@jsvd jsvd reopened this May 3, 2017
@jsvd jsvd force-pushed the make_flags_e_f_mutually_exclusive branch 2 times, most recently from 244395a to a20d2df Compare May 8, 2017 11:18
@jsvd jsvd force-pushed the make_flags_e_f_mutually_exclusive branch from a20d2df to b8b4dd7 Compare May 9, 2017 10:46
@jsvd jsvd merged commit 07194b8 into elastic:master May 9, 2017
@jsvd jsvd deleted the make_flags_e_f_mutually_exclusive branch May 9, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants